Migrate the Shopper Renew Subscription E2E test to Playwright #10144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoumpierre
commented
Jan 13, 2025
| await navigation.goToSubscriptions( page ); | ||
|
|
||
| if ( ! subscriptionId ) { | ||
| throw new Error( 'Subscription ID is not set' ); |
There was a problem hiding this comment.
I added this throw to provide a better error in case the previous test fails. We can remove it if not desired.
eduardoumpierre
commented
Jan 13, 2025
| export const shouldRunSubscriptionsTests = | ||
| process.env.SKIP_WC_SUBSCRIPTIONS_TESTS !== '1'; | ||
|
|
||
| export const products = { |
There was a problem hiding this comment.
I'm unsure about the names of those constants. I wanted to use SHOULD_RUN_SUBSCRIPTIONS_TESTS and PRODUCTS, but since ESLint flagged it, I opted to keep both in lower camel case for now.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
eduardoumpierre
commented
Jan 13, 2025
tests/e2e-pw/utils/rest-api.ts
Outdated
| * @param {string} emailAddress Customer user account email address. | ||
| * @return {Promise<void>} | ||
| */ | ||
| export const deleteCustomerByEmailAddress = async ( emailAddress: string ) => { |
There was a problem hiding this comment.
I spent quite some time troubleshooting this issue. I initially tried using the function from WC's test utils, which is used by the Puppeteer tests, but consistently encountered the following error:
Error: Configuration property "url" is not defined
at Config.get (/woopayments/node_modules/@woocommerce/e2e-utils/node_modules/config/lib/config.js:182:11)
at Object.<anonymous> (/Users/ronrennick/Sites/solaris/woocommerce/packages/js/e2e-utils/src/factories.js:8:23)
at Object.<anonymous> (/Users/ronrennick/Sites/solaris/woocommerce/packages/js/e2e-utils/src/index.js:8:1)
at Object.<anonymous> (/woopayments/tests/e2e-pw/specs/shopper/shopper-myaccount-renew-subscription.spec.ts:6:25)
I attempted to resolve this by adding default.json and test.json with the required keys to the e2e-pw/config folder, following the existing pattern, but it didn’t work. After trying multiple approaches without success, I ended up duplicating the original function and modifying it to work on our setup.
eduardoumpierre
commented
Jan 13, 2025
| let page: Page; | ||
|
|
||
| test.beforeAll( async ( { browser }, { project } ) => { | ||
| const restApi = new RestAPI( project.use.baseURL ); |
There was a problem hiding this comment.
We're using project.use.baseURL to get the same base URL Playwright is using while running the tests.
|
I've run the tests 3 times, and I'm getting this error: and the screenshot shows:
Maybe that's something wrong with my local setup. Also I get this warning: |
…myaccount-renew-subscription-e2e-test
|
Thanks for running the tests, @tpaksu! I’d recommend resetting your E2E environment and running
Most of the tests get the warning because the whole spec takes more than X seconds (what it considers slow). Unfortunately, in this case, the tests are co-dependent so we couldn't do something like that. |
|
@eduardoumpierre I've done those as they are mentioned in the testing instructions :) I've also run |
|
Thanks for letting me know! I’ll try a different approach to have the checkout form ready for submission. |
tpaksu
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Okay, the E2E tests on my local also passed, turns out that my site had card testing prevention enabled, which gave the error on my previous comment. Disabling the flag and refreshing the cache let the renewal pass through. But as we talked on Slack, we should better check if the card testing prevention token is being rendered on the renewal checkout page, as it shouldn't be failing. Maybe we can extend the tests to test the card testing prevention tokens too in a different issue.
Thanks for working on this, we can ship it!
eduardoumpierre
deleted the
dev/10084-shopper-myaccount-renew-subscription-e2e-test
branch
leonardola
pushed a commit
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10084
Changes proposed in this Pull Request
This PR aims to migrate the "Subscriptions > Renew a subscription in my account" spec to Playwright, removing the corresponding test from the Puppeteer test suite.
Testing instructions
npm run test:e2e-resetnpm run test:e2e-setupnpm run test:e2e-pw shopper-myaccount-renew-subscriptionnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge